Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rules parse message: Expected one of ... #802

Closed
jw3 opened this issue Mar 2, 2023 · 0 comments · Fixed by #845
Closed

Rules parse message: Expected one of ... #802

jw3 opened this issue Mar 2, 2023 · 0 comments · Fixed by #845
Labels
bug Something isn't working rules
Milestone
v1.1

Comments

@jw3
Copy link
Member

jw3 commented Mar 2, 2023

The text of a rule syntax error message was apparently a todo and displays as

Expected one of ...

Originates in the Display impl for RuleParseError in rules::parser::error

UnknownSubjectPart(_) | UnknownObjectPart(_) => f.write_str("Expected one of ....."),

Simple fix here is to break those to separate lines and change the message respectively to Expected subject and Expected object
@jw3 jw3 added bug Something isn't working rules labels Mar 2, 2023
@jw3 jw3 added this to the v1.1 milestone Mar 12, 2023
@jw3 jw3 mentioned this issue Apr 6, 2023
Merged
@jw3 jw3 closed this as completed in #845 Apr 10, 2023
jw3 added a commit that referenced this issue Apr 10, 2023
@jw3
Clarify unknown part message on rule parse (#845)
c9eb33d 
Clarifies the unknown subject|object messages from the parser.

Closes #802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working rules
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

Clarify unknown part message on rule parse jw3/fapolicy-analyzer
1 participant
@jw3