Black and flake8 formatting and adding flake8 in CI

[sona-patel]

This PR formats the entire nectarchain according to black and flake8 style!

[codecov]

Codecov Report

Patch coverage: 0.07% and project coverage change: -0.02 ⚠️

Comparison is base (7a01121) 0.53% compared to head (b8dbdb9) 0.52%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master     #49      +/-   ##
=========================================
- Coverage    0.53%   0.52%   -0.02%     
=========================================
  Files          23      17       -6     
  Lines        2427    2478      +51     
=========================================
  Hits           13      13              
- Misses       2414    2465      +51     

Impacted Files	Coverage Δ
...hain/calibration/NectarGain/PhotoStat/PhotoStat.py	0.00% <0.00%> (ø)
...in/calibration/NectarGain/SPEfit/NectarGAIN_old.py	0.00% <0.00%> (ø)
...ain/calibration/NectarGain/SPEfit/NectarGainSPE.py	0.00% <0.00%> (ø)
...ration/NectarGain/SPEfit/NectarGainSPE_combined.py	0.00% <0.00%> (ø)
...ation/NectarGain/SPEfit/NectarGainSPE_singlerun.py	0.00% <0.00%> (ø)
...rchain/calibration/NectarGain/SPEfit/parameters.py	0.00% <0.00%> (ø)
...nectarchain/calibration/NectarGain/SPEfit/utils.py	0.00% <0.00%> (ø)
.../nectarchain/calibration/NectarGain/utils/error.py	0.00% <0.00%> (ø)
src/nectarchain/calibration/container/charge.py	0.00% <0.00%> (ø)
...tarchain/calibration/container/charge_extractor.py	0.00% <0.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jlenain]

Hi @sona-patel ,
As discussed during the last NectarCAM scientific software meeting, sorry for overlooking this PR.
I would suggest to split the linting part from the integration into the CI. Concerning the latter, it would be best to simply use a GitHub action, such as:
https://github.com/py-actions/flake8
instead of calling flake8 on each part of the code.

Concerning the former, could you please resolve the current merge conflicts ?

[sona-patel]

Hi @jlenain, thanks for looking into it. Agreed to use py-actions/flake8 instead of calling flake8.

• resolve the merge conflicts
• separate the linting and CI parts

Closed by mistake! Will open new PRs for each of the above two todo!