Improvement of the data management and naming of containers files #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 7, 2025 16:43
… provided -> not anymore sensitive to the order of kargs given by user -> It deals smoothly If user set kwargs to default value
-> Exception raised and cautch properly when file no found
guillaumegrolleron
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 63.24% 62.58% -0.66%
==========================================
Files 64 66 +2
Lines 4734 4886 +152
==========================================
+ Hits 2994 3058 +64
- Misses 1740 1828 +88 ☔ View full report in Codecov by Sentry. |
jlenain
reviewed
Feb 7, 2025
|
Thanks a lot, @guillaumegrolleron ! I'll review the changes in more details a bit later, but at least I confirm that this PR solves #178 . |
jlenain
approved these changes
Feb 10, 2025
jlenain
pushed a commit
to jlenain/nectarchain
that referenced
this pull request
Feb 11, 2025
…a-observatory#181) * cleaner way to get the extractor string asociated to extractor kwargs provided -> not anymore sensitive to the order of kargs given by user -> It deals smoothly If user set kwargs to default value * The search of saved containers (SPE,Charge,wfs) is more robust -> Exception raised and cautch properly when file no found * propagation of changes in makers * script updates + fix of broken photostat code * update of shell scripts --------- Co-authored-by: guillaume.grolleron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix several bugs and is an improvement of the data management and the naming of conainers files when stored on disk.
The behavior of scripts for gain computation, with the SPE fit or photo-stat method are more robust, as well as the charge computation.