Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 20240917_v0.10.12_src15_dec_min_2924_tuned #508

Merged
merged 14 commits into from
Nov 12, 2024

Conversation

nikoliclisa
Copy link
Contributor

@nikoliclisa nikoliclisa commented Oct 25, 2024

New Prod config

Self check-list:

  • I have checked the lstchain config, in particular for:
    • az_tel instead of sin_az_tel if data to be analyzed have been produced with lstchain <= v0.9.7
    • "increase_nsb" and "increase_psf" are provided in "image_modifier" (if used)
  • I have checked the environment in the lstmcpipe config and it is the one used to analyse DL>1 data
  • I have provided the command (in README), or script (in additionnal .py file) used to produce the lstmcpipe config

Prod_ID

Short description of the config

Why this config is needed

@nikoliclisa
Copy link
Contributor Author

Hi @vuillaut
I have modified the branch 20240917_v0.10.12_src15_dec_min_2924_tuned with updated(corrected) files. Could you please check it and let me know if everything is fine.
Thank you.

@nikoliclisa
Copy link
Contributor Author

Hi @vuillaut
I just wanted to make sure you saw the recent updates. Let me know if anything else needs to be modified.

@nikoliclisa
Copy link
Contributor Author

@vuillaut I have rechecked and updated the lstmcpipe config (yaml) file but I am getting the error '! Subdirectories with the same PROD_ID and analysed the same day will be overwritten !' in the CI tests. Could you please check and let me know of the error?
Thank you

@nikoliclisa nikoliclisa requested a review from vuillaut November 7, 2024 16:10
@vuillaut
Copy link
Member

vuillaut commented Nov 7, 2024

@vuillaut I have rechecked and updated the lstmcpipe config (yaml) file but I am getting the error '! Subdirectories with the same PROD_ID and analysed the same day will be overwritten !' in the CI tests. Could you please check and let me know of the error? Thank you

Hi.
That's not actually the error your are getting.
The error is:

json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 307 column 1 (char 8273)

showing that your JSON file (so the lstchain config) is not correct

@vuillaut vuillaut merged commit b4baa82 into master Nov 12, 2024
7 checks passed
@vuillaut
Copy link
Member

vuillaut commented Dec 3, 2024

Hi @nikoliclisa
The production is done !
You may find models at /fefs/aswg/data/models/AllSky/20240917_v0.10.12_src15_dec_min_2924_tuned/dec_min_2924/
and dl2 data at /fefs/aswg/data/mc/DL2/AllSky/20240917_v0.10.12_src15_dec_min_2924_tuned/TestingDataset/dec_min_2924/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants