Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2-Pass waveform integration à-la-CTA/MARS #1215

Merged
merged 33 commits into from
May 11, 2020
Merged

2-Pass waveform integration à-la-CTA/MARS #1215

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
6abcb5a
Added new TwoPassWindowSum ImageExtractor instance with its unit-test…
Jan 28, 2020
1e8ee5a
Updated slide_windows with better docs and variable names.
Feb 21, 2020
ed8e89e
Corrected and updated TwoPassWindowSum.
Feb 21, 2020
0795d9b
Fixed error for which array images were referring always to the same …
Feb 21, 2020
67f804f
Changed core thresholds as TelescopeParameter.
Feb 21, 2020
219b3b7
Added references to class documentation.
Feb 25, 2020
4b93a59
Updated CODEOWNERS file.
Feb 25, 2020
37fc9a8
Merge branch 'master' into feature/TwoPassWindowSum_ImageExtractor
Mar 25, 2020
04efa88
Merge branch 'master' into feature/TwoPassWindowSum_ImageExtractor
Apr 1, 2020
85c1603
Merge branch 'master' into feature/TwoPassWindowSum_ImageExtractor
Apr 6, 2020
679148f
Fixed merge conflicts and updated code ( class definition + unit-test).
Apr 7, 2020
eaaaf54
Fixed documentation references.
Apr 7, 2020
d82a42e
Merge branch 'master' into feature/TwoPassWindowSum_ImageExtractor
Apr 8, 2020
309cb29
Merge branch 'master' into feature/TwoPassWindowSum_ImageExtractor
Apr 8, 2020
ddd53b3
Fix docstring formatting
maxnoe Apr 9, 2020
7ea37cf
Merge pull request #1 from cta-observatory/twopass
HealthyPear Apr 9, 2020
264ce9c
Merge branch 'feature/TwoPassWindowSum_ImageExtractor' of https://git…
Apr 9, 2020
5c33d02
Revert subarray as a specific argument in ImageExtractor initialization.
May 4, 2020
88cf166
use relative imports
May 4, 2020
d314201
Merge branch 'master' into feature/TwoPassWindowSum_ImageExtractor
May 4, 2020
44919b7
Added changes required to run the test as before.
May 4, 2020
8af5cb6
Added parametrizable toymodel
May 4, 2020
687f30e
Updated test function
May 4, 2020
d4e1490
Call get_test_toymodel in toymodel to remove duplicated code.
May 4, 2020
d4be780
Merge branch 'master' into feature/TwoPassWindowSum_ImageExtractor
HealthyPear May 6, 2020
f44f934
Make _calculate_correction a private method for each image extractor.
HealthyPear May 6, 2020
1cc8828
Hide unused variable for transverse COG coordinate.
HealthyPear May 6, 2020
1a648a5
Fix error in test (it was always running only for 1 to 10 phe!)
HealthyPear May 7, 2020
058b9f2
Multiple changes, see description.
HealthyPear May 7, 2020
399c411
Few formatting changes via black.
HealthyPear May 7, 2020
0e03efa
Merge branch 'master' into feature/TwoPassWindowSum_ImageExtractor
HealthyPear May 7, 2020
6f55ce6
Spurious lines from merge conflict removed.
HealthyPear May 7, 2020
4e20ffe
Removed unnecessary 'else' clauses.
HealthyPear May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
# https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

ctapipe/calib/camera @watsonjj
ctapipe/image/extractor.py @watsonjj
ctapipe/image/extractor.py @watsonjj @HealthyPear
Loading