Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postcss-tape : type checker #1282

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Feb 14, 2024

Not sure about this one yet, but it seemed useful.

It's relatively easy to mess up a single prop assignment that isn't immediately visible to us in our own tests.

rule.selector = ['.foo', '.bar'];

That would still serialize fine because an array of strings happens to concat with , by default in JavaScript.

But another plugin doing selector.replace(...) would get an on such a node.

see : postcss/postcss-import#557

@romainmenke
Copy link
Member Author

Going to close for now, we already have TypeScript to guard against the same underlying issue.

@romainmenke romainmenke deleted the postcss-tape--type-checks--exuberant-gentoo-penguin-ecb029cd9f branch February 19, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant