test for mixed components #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugins/postcss-lab-function
plugin-packs/postcss-preset-env
plugins/postcss-color-function
plugins/postcss-progressive-custom-properties
plugins/postcss-oklab-function
plugins/postcss-gradients-interpolation-method
plugins/postcss-color-mix-function
plugins/postcss-relative-color-syntax
plugins/postcss-slow-plugins
labels
…ssuming-cuttlefish-0105db9e41
…ssuming-cuttlefish-0105db9e41
…ssuming-cuttlefish-0105db9e41
…ssuming-cuttlefish-0105db9e41
This reverts commit 8c1595b.
romainmenke
deleted the
mixed-components--unassuming-cuttlefish-0105db9e41
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #1176
this is a breaking change, how can we make it safe to roll out?This is a breaking change because wide gamut colors are linked to the new color notations.
We can create new plugins to downgrade mixed numbers and percentages. But this seems like overkill to me.
Or we can adjust the support data for each notation to also cover this aspect.
But then some users who might have seen wide gamut colors would receive the fallback
srgbcolor when they support the new notations, but not mixed numbers and percentages.I think this is fine if all latest versions of all browsers support the latest syntax and if those versions have sufficient adoption.
It's not fine if too many people would suddenly lose access to wide gamut colors.
Update:
Enough time has passed to make the actual impact quite small.
CSS authors can avoid this issue for now by not mixing
numbersandpercentages.