PR from local brach to run the CI #936 #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a completely bundled distribution, ready importing from CDNs like unpkg.com for use in sandboxes like Codepen. It allows this code to work:
```typescript
import { create as createJSS } from 'https://unpkg.com/jss';
```
The PR is a work-in-progress, but I'd rather start a conversation with an example than with prose. As it is, I can't get `sizeSnapshot` to work with the bundled version.
I also wonder how best to handle plugins/presets. The easiest options would be to add `unpkg` entry points to each `package`, and force authors to use multiple imports:
```typescript
import { create as createJSS } from 'https://unpkg.com/jss';
import createDefaultJSSPreset from 'https://unpkg.com/jss-preset-default';
```
I wonder what the best way to produce a batteries-included bundle is. Perhaps there should be another bundle `jss-all` that exports all the other packages. Then usage would be:
```typescript
import * as jssAll from 'https://unpkg.com/jss-all';
const jss = jssAll.create(jssAll.preset());
```
|
🎉🎉🎉 |
bhupinderbola
pushed a commit
to bhupinderbola/jss
that referenced
this pull request
Sep 17, 2019
* Add `unpkg` key to package.json
This provides a completely bundled distribution, ready importing from CDNs like unpkg.com for use in sandboxes like Codepen. It allows this code to work:
```typescript
import { create as createJSS } from 'https://unpkg.com/jss';
```
The PR is a work-in-progress, but I'd rather start a conversation with an example than with prose. As it is, I can't get `sizeSnapshot` to work with the bundled version.
I also wonder how best to handle plugins/presets. The easiest options would be to add `unpkg` entry points to each `package`, and force authors to use multiple imports:
```typescript
import { create as createJSS } from 'https://unpkg.com/jss';
import createDefaultJSSPreset from 'https://unpkg.com/jss-preset-default';
```
I wonder what the best way to produce a batteries-included bundle is. Perhaps there should be another bundle `jss-all` that exports all the other packages. Then usage would be:
```typescript
import * as jssAll from 'https://unpkg.com/jss-all';
const jss = jssAll.create(jssAll.preset());
```
* Add jss-starter-kit
* Fixed grammar in warning
* update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.