Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hoisting of new react features #925

Merged
merged 2 commits into from
Nov 28, 2018

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Nov 28, 2018

What would you like to add/fix?

  • hoisting of new react features

Corresponding issue (if exists):
cssinjs/react-jss#314

[email protected] does not support forwardRef components, contextType static nor getDerivedStateFromError static. The major version bump was due to the added requirement of react >= 0.14 which was dropped in [email protected]. Therefore this change should not be breaking.

hoist-non-react-statics changelog

@HenriBeck
Copy link
Member

HenriBeck commented Nov 28, 2018

Please run yarn build to update the size snapshots.
Otherwise, the PR looks good.

I will merge once the size snapshots are updated.

@eps1lon
Copy link
Member Author

eps1lon commented Nov 28, 2018

@HenriBeck CI failures look unrelated. Do you want me to push an empty commit to trigger a build or are you taking care of this?

@HenriBeck
Copy link
Member

HenriBeck commented Nov 28, 2018 via email

@kof kof merged commit 9b87545 into cssinjs:master Nov 28, 2018
@kof
Copy link
Member

kof commented Nov 28, 2018

Thanks, merged

@eps1lon eps1lon deleted the fix/hoisting-new-react-features branch November 28, 2018 19:09
HenriBeck pushed a commit that referenced this pull request Dec 3, 2018
…t-jss/jss-context

* origin/react-jss/jss-context:
  Fix hoisting of new react features (#925)
bhupinderbola pushed a commit to bhupinderbola/jss that referenced this pull request Sep 17, 2019
* Fix hoisting of new react features

* Update size-snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants