-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1207 - update stylesheet if !important is set #1612
Conversation
Can you add a test please? |
Sure, please tell me what kind of test do you mean? |
since this bug is in dom renderer, it will need a functional test that reads the applied css from the dom, some examples https://github.com/cssinjs/jss/blob/master/packages/jss/tests/functional/sheet.js#L548 |
Great, I'm on it |
@kof Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found another thing that may potentially improve performance of this quite a bit
merged 🎉 |
Corresponding Issue(s): #1207
What Would You Like to Add/Fix?
Update stylesheet if
!important
flag is set before and after the updateTodo
Changelog
!important
flag