Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1207 - update stylesheet if !important is set #1612

Merged
merged 4 commits into from
Apr 24, 2022
Merged

Conversation

behnammodi
Copy link
Member

Corresponding Issue(s): #1207

What Would You Like to Add/Fix?

Update stylesheet if !important flag is set before and after the update

Todo

  • All tests passed
  • It wasn't a public API

Changelog

  • A issue is about when you want to update a CSS rule value with a !important flag

@kof
Copy link
Member

kof commented Apr 24, 2022

Can you add a test please?

@behnammodi
Copy link
Member Author

Sure, please tell me what kind of test do you mean?

@kof
Copy link
Member

kof commented Apr 24, 2022

since this bug is in dom renderer, it will need a functional test that reads the applied css from the dom, some examples https://github.com/cssinjs/jss/blob/master/packages/jss/tests/functional/sheet.js#L548

@behnammodi
Copy link
Member Author

since this bug is in dom renderer, it will need a functional test that reads the applied css from the dom, some examples https://github.com/cssinjs/jss/blob/master/packages/jss/tests/functional/sheet.js#L548

Great, I'm on it

@behnammodi
Copy link
Member Author

@kof Done

@behnammodi behnammodi requested a review from kof April 24, 2022 19:07
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found another thing that may potentially improve performance of this quite a bit

@behnammodi behnammodi closed this Apr 24, 2022
@behnammodi behnammodi reopened this Apr 24, 2022
@behnammodi behnammodi requested a review from kof April 24, 2022 20:43
@kof kof merged commit 83afc1b into cssinjs:master Apr 24, 2022
@kof
Copy link
Member

kof commented Apr 24, 2022

merged 🎉

@kof
Copy link
Member

kof commented Apr 24, 2022

released https://github.com/cssinjs/jss/releases/tag/v10.9.1-alpha.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants