Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add px as default unit for text-decoration-thickness property #1438

Merged
merged 1 commit into from
Jan 4, 2021
Merged

feat: add px as default unit for text-decoration-thickness property #1438

merged 1 commit into from
Jan 4, 2021

Conversation

vepasto
Copy link
Contributor

@vepasto vepasto commented Jan 4, 2021

Corresponding issue (if exists):

#1437

What would you like to add/fix?

Todo

  • Add tests if possible
  • Add changelog if users should know about the change
  • Add documentation

@vepasto vepasto requested a review from HenriBeck as a code owner January 4, 2021 10:50
@kof kof merged commit acd2c75 into cssinjs:master Jan 4, 2021
@kof
Copy link
Member

kof commented Jan 4, 2021

thanks

kof added a commit that referenced this pull request Jan 19, 2021
)

* fix(react-jss): Media query styles applied only to the first element in function

chore(react-jss): Snapshot update

* tests(react-jss): added tests for createUseStyles

* added createBasicStyles call to createUseStyles test

* added media query test to createBasicTests

* feat: add px as default unit for text-decoration-thickness property (#1438)

* remove duplicate test

* rename basic to common

* rename test generator functions

* move the test where it belongs

* better comments

Co-authored-by: Pranshu Chittora <[email protected]>
Co-authored-by: Matt Beaudry <[email protected]>
Co-authored-by: Veikko Karsikko <[email protected]>
@kof
Copy link
Member

kof commented Jan 23, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants