perf: remove test files from the package

[RobertAron]

Corresponding issue (if exists):

#979

What would you like to add/fix?

Prevent the test files from being published to NPM.

I'm not super comfortable with how lerna works, but I believe this is what's needed.

Todo

• Add tests if possible (N/A)
• Add changelog if users should know about the change (N/A)
• Add documentation (N/A)

[kof]

files is actually defining what should be in the package, we don't need to define what should not be in the package in addition

[kof]

oh you are talking about the tests which are next to the src files

[kof]

I wonder as well if that works, because it's a negative match, so it will probably just do nothing and move on to src and still match everything

[RobertAron]

I tried with npm pack and thought it was working but just double-checked and I'm not so sure anymore...

I'll fiddle with it a bit more.

[kof]

otherwise I only see .npmignore as an option

[RobertAron]

I was able to glob ignore specifically the files that end in .test.js that are in the src folders. I could setup .npmignore instead if you think that's a cleaner approach.

Edit: actually I think this removed some of the other files though. I'll continue to look at it.

[RobertAron]

Pretty confident it's in a good state now. Here are the cases I was thinking about.

[kof]

yeah, that glob looks scary, at this point I think .npmignore is cleaner

[RobertAron]

I agree it's a little scary 😬

Apparently files included with the “package.json#files” field cannot be excluded through .npmignore or .gitignore. I wasn't sure if you meant to pull the files out of the package.json so I kept looking for a better solution.

I found someone suggested doing what I was doing originally so I went back to looking into it. Apparently what I did works, but you have to do it in a specific order. Let me know if that's an ok solution.

Also that link I included above mentions that files called LICENSE should be included no matter what you do, so I think it could be taken out of the array. For now, I left it in just in case there was some reason for it to be there.

[kof]

LiCENSE is included automatically, no need for listing it

…

On 12. Oct 2020, at 00:59, RobertAron ***@***.***> wrote: @RobertAron commented on this pull request. In packages/css-jss/package.json <#1406 (comment)>: > @@ -17,6 +17,7 @@ "url": "https://github.com/cssinjs/jss/issues/new" }, "files": [ + "!*.test.js", I agree it's a little scary 😬 Apparently files included with the “package.json#files” field cannot be excluded through .npmignore or .gitignore <https://docs.npmjs.com/files/package.json>. I wasn't sure if you meant to pull the files out of the package.json so I kept looking for a better solution. I found someone suggested doing what I was doing originally so I went back to looking into it. Apparently what I did works, but you have to do it in a specific order. Let me know if that's an ok solution. Also that link I included above mentions that files called LICENSE should be included no matter what you do, so I think it could be taken out of the array. For now, I left it in just in case there was some reason for it to be there. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1406 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAM4WCQZHL7FXTC3KBZA2DSKI2EVANCNFSM4SLKAKRQ>.

[kof]

checked, it works, thank you