Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(units): add gap #1403

Merged
merged 1 commit into from
Nov 10, 2020
Merged

feat(units): add gap #1403

merged 1 commit into from
Nov 10, 2020

Conversation

moshfeu
Copy link
Contributor

@moshfeu moshfeu commented Oct 7, 2020

Corresponding issue (if exists):

resolve #1348

What would you like to add/fix?

Add gap to defaultUnits

Todo

  • Add tests if possible
  • Add changelog if users should know about the change
  • Add documentation

@moshfeu moshfeu requested a review from HenriBeck as a code owner October 7, 2020 15:58
@kof
Copy link
Member

kof commented Oct 7, 2020

I would place it right after grid-gap, since the later was deprecated, also not sure if we still need to support grid-gap

@moshfeu
Copy link
Contributor Author

moshfeu commented Oct 7, 2020 •
edited
Loading

I wasn't sure because it also affect on flex, let me know.

https://codesandbox.io/s/material-demo-ythj8?file=/demo.js

@kof kof merged commit 016eeab into cssinjs:master Nov 10, 2020
@kof
Copy link
Member

kof commented Nov 10, 2020

merged, thanks

@moshfeu moshfeu deleted the patch-1 branch November 10, 2020 11:00
@kof
Copy link
Member

kof commented Nov 15, 2020

https://github.com/cssinjs/jss/releases/tag/v10.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenriBeck HenriBeck Awaiting requested review from HenriBeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS Property gap not receiving a default unit
2 participants
@moshfeu @kof