Restore TypeScript support for Observable styles #1402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding issue (if exists):
What would you like to add/fix?
should work in TypeScript, and used to work with
@types/jss
. JSS now supplies its own types, which don't includeObservable
support. This PR adds them back.As @worudso alluded to in #1035, a better solution would only include the
Observable
type if users had installed the Observable plugin. Otherwise, users could be frustrated if the typecheck passes forcreateStyleSheet(someObservables)
but it fails at runtime.However, that solution would require bigger and more thoughtful changes to the typings. This PR is a quick fix that addresses the regression from
@types/jss
, while leaving the work of a refactor to a future PR.Todo
Add documentation