Fix typspec for default unit plugin #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kof
approved these changes
Apr 3, 2019
|
thanks |
|
@kof I was questioning myself if you were a bot, that was quick 😆 |
|
not a bot, but a bot would say the same |
HenriBeck
pushed a commit
that referenced
this pull request
Apr 14, 2019
* master: (24 commits) Fix #1084 (#1085) Update size snapshots [jss-plugin-expand]Added the ability to expand the attributes for border-bottom (#1083) Update react-jss.md (#1078) Fix typspec for default unit plugin (#1077) Delete CNAME Create CNAME v10.0.0-alpha.16 fix versions manually update changelog, make build Add local yarn version (#1071) update snapshots Update size-snapshots v10.0.0-alpha.15 update changelog, make build Update to [email protected] (#1068) Improve IE 11 support (#1065) fix changelog v10.0.0-alpha.14 [jss] Add support for multiple referenced keyframes (#1063) ... # Conflicts: # packages/jss-plugin-default-unit/.size-snapshot.json # packages/jss-preset-default/.size-snapshot.json # packages/jss-starter-kit/.size-snapshot.json # packages/jss/.size-snapshot.json # packages/react-jss/.size-snapshot.json # packages/react-jss/src/types.js # packages/react-jss/src/withStyles.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that this plugin does not require me to pass the options.
jss/packages/jss-plugin-default-unit/src/index.js
Line 63 in 27e2428
But the typespec is forcing me to pass a value.