-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
falling demo #25
base: master
Are you sure you want to change the base?
falling demo #25
Conversation
Also I think, that _compose_node_module_cool_styles_foo__example is not a valid generated class name, because it is a part of the external module. Took me some time figure out why that problem appear. When { [Error: ENOENT, open '/home/travis/build/css-modules/css-modules-loader-core/test/test-cases/compose-node-module/cool-styles/bar.css']
errno: -2,
code: 'ENOENT',
path: '/home/travis/build/css-modules/css-modules-loader-core/test/test-cases/compose-node-module/cool-styles/bar.css' } |
I think that we should pass an absolute path to the source file as an extra argument to the parser plugin, so it can possible to put it back to the That will help us to resolve paths and build rootRelativePath. What you think about it? |
importNode.each( decl => { | ||
if ( decl.type == 'decl' ) { | ||
this.translations[decl.prop] = exports[decl.value] | ||
} | ||
} ) | ||
importNode.removeSelf() | ||
}, err => console.log( err ) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are handling error at the file-system-loader
module, so no need to do it here.
Hi, looks like I found a nasty bug :)