Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying AD backend in config #10

Merged
merged 7 commits into from
Jul 14, 2021

Conversation

sethaxen
Copy link
Collaborator

As discussed on slack, this PR adds the ad_backend kwarg to dynamichmc. It also adds a number of explicit tests.

@sethaxen sethaxen requested a review from cscherrer July 14, 2021 09:56
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #10 (ff7f162) into master (0a5c0cc) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   97.22%   97.05%   -0.17%     
==========================================
  Files           1        1              
  Lines          36       34       -2     
==========================================
- Hits           35       33       -2     
  Misses          1        1              
Impacted Files Coverage Δ
src/SampleChainsDynamicHMC.jl 97.05% <100.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a5c0cc...ff7f162. Read the comment docs.

Copy link
Owner

@cscherrer cscherrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @sethaxen !

@cscherrer cscherrer merged commit da702e2 into cscherrer:master Jul 14, 2021
@sethaxen sethaxen deleted the ad_backend branch July 14, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants