Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lib50 requirement, bump version #290

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Conversation

rongxin-liu
Copy link
Contributor

Would the latest version of lib50 touch help50? I tested help50 with the latest version of lib50, and it seemed working fine, but I just want to double-check in case I overlooked something.

@rongxin-liu
Copy link
Contributor Author

PS: cs50/cli was using help50 version 3.0.2 instead of the latest version (3.0.4) due to lib50 requirement.

@dmalan
Copy link
Member

dmalan commented Aug 8, 2021

@Jelleas @cmlsharp any concerns here?

@Jelleas
Copy link
Contributor

Jelleas commented Aug 9, 2021

Nope, should be fine! The only thing the latest lib50 changed was an option to set a custom honesty prompt. As far as I know, it's just submit50 that needed changes.

@rongxin-liu
Copy link
Contributor Author

Nope, should be fine! The only thing the latest lib50 changed was an option to set a custom honesty prompt. As far as I know, it's just submit50 that needed changes.

Sounds good, thank you!

@rongxin-liu rongxin-liu merged commit 928417d into main Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants