Thread Safe Connection Pool #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
approved these changes
Jun 30, 2020
|
while a lock might be faster this PR at least makes the implementation concurrency safe. The locks require more management and the whole pool is in the todo package anyway. Good enough for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We encountered
concurrent map writesruntime errors on the pool package. This solution should address this error and provide with a safe way to access these data structures. Since they are not exported and thesync.Mapworks withinterface{}, a type assertion is needed, making it hard to refactor this code since generics are non-existant in go (at the moment of this writing), and reflection will definitely under perform on this package, which is sort of a bottleneck.closes #908
ping @butonic @individual-it