Disable open in app for given paths

changelog/unreleased/disable-open-in-app.md

@@ -0,0 +1,3 @@
+Enhancement: Disable open in app for given paths
+
+https://github.com/cs3org/reva/pull/4304

internal/http/services/owncloud/ocdav/ocdav.go

@@ -119,6 +119,7 @@ type Config struct {
 	FavoriteStorageDriver  string                            `mapstructure:"favorite_storage_driver"`
 	FavoriteStorageDrivers map[string]map[string]interface{} `mapstructure:"favorite_storage_drivers"`
 	PublicLinkDownload     *ConfigPublicLinkDownload         `mapstructure:"publiclink_download"`
+	DisabledOpenInAppPaths []string                          `mapstructure:"disabled_open_in_app_paths"`
 	Notifications          map[string]interface{}            `docs:"Settingsg for the Notification Helper" mapstructure:"notifications"`
 }
 

internal/http/services/owncloud/ocdav/propfind.go

@@ -514,6 +514,27 @@ func supportLegacyOCMAccess(ctx context.Context, md *provider.ResourceInfo) {
 	}
 }
 
+func appendSlash(path string) string {
+	if path == "" {
+		return "/"
+	}
+	if path[len(path)-1] == '/' {
+		return path
+	}
+	return path + "/"
+}
+
+func (s *svc) isOpenable(path string) bool {
+	path = appendSlash(path)
+	path = filepath.Join("/", path)
+	for _, prefix := range s.c.DisabledOpenInAppPaths {
+		if strings.HasPrefix(path, appendSlash(prefix)) {
+			return false
+		}
+	}
+	return true
+}
+
 // mdToPropResponse converts the CS3 metadata into a webdav PropResponse
 // ns is the CS3 namespace that needs to be removed from the CS3 path before
 // prefixing it with the baseURI.
@@ -567,6 +588,7 @@ func (s *svc) mdToPropResponse(ctx context.Context, pf *propfindXML, md *provide
 			isShared,
 			false,
 			isPublic,
+			s.isOpenable(md.Path),
 		)
 		sublog.Debug().Interface("role", role).Str("dav-permissions", wdp).Msg("converted PermissionSet")
 	}

internal/http/services/owncloud/ocdav/tus.go

@@ -303,6 +303,7 @@ func (s *svc) handleTusPost(ctx context.Context, w http.ResponseWriter, r *http.
 				isShared,
 				false,
 				isPublic,
+				s.isOpenable(info.Path),
 			)
 
 			w.Header().Set(HeaderContentType, info.MimeType)

internal/http/services/owncloud/ocs/conversions/role.go

@@ -96,8 +96,9 @@ func (r *Role) OCSPermissions() Permissions {
 // S = Shared
 // R = Shareable
 // M = Mounted
-// Z = Deniable (NEW).
-func (r *Role) WebDAVPermissions(isDir, isShared, isMountpoint, isPublic bool) string {
+// Z = Deniable
+// O = Openable.
+func (r *Role) WebDAVPermissions(isDir, isShared, isMountpoint, isPublic, isOpenable bool) string {
 	var b strings.Builder
 	if !isPublic && isShared {
 		fmt.Fprintf(&b, "S")
@@ -125,6 +126,10 @@ func (r *Role) WebDAVPermissions(isDir, isShared, isMountpoint, isPublic bool) s
 		fmt.Fprintf(&b, "Z")
 	}
 
+	if isOpenable && !isDir {
+		fmt.Fprintf(&b, "O")
+	}
+
 	return b.String()
 }