Refurbish the grpc and http plugins for eos #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffurano
requested review from
labkode,
glpatcern and
gmgigi96
as code owners
gmgigi96
requested changes
Sep 21, 2023
gmgigi96
requested changes
Sep 21, 2023
|
What is the issue of re-using existing context? |
|
For the test command, true that we want to expose the CLI at some point but at that point we can comment this @gmgigi96 can you approve? |
I'm with @ffurano to understand this - apparently the GRPC client for eos needs an empty context and breaks if we reuse the incoming reva-created |
glpatcern
previously approved these changes
Oct 9, 2023
gmgigi96
reviewed
Oct 10, 2023
Co-authored-by: Gianmaria Del Monte <[email protected]>
gmgigi96
added a commit
to cernbox/reva
that referenced
this pull request
Oct 24, 2023
* For GRPC to EOS use the app context, not the passed one * Refresh compiling the eosgrpc proto * eos_grpc: small fixes * Add teststorageperf reva shell command * Refurbish the grpc and http plugins for eos * Add README for how to compile the grpc intf to eos * Add test self-referential release note * Modify test self-referential release note * Modify test self-referential release note * Cosmetics * NSRequests: use the background context to avoid grpc ugly bug * Fix lint warning * Close the body of an http get when not needed anymore * Fix lint warning * Set cmd timeout to 15s (allows uploading larger files to loaded servers) * eosgrpc: use a clean context derived from the original one * Makefile: use gaia to build revad * Fix lint warning * Add new target cernbox-revad, using gaia to build revad * go lint-fix * Update Makefile Co-authored-by: Gianmaria Del Monte <[email protected]> --------- Co-authored-by: Fabrizio Furano <[email protected]> Co-authored-by: Gianmaria Del Monte <[email protected]>
gmgigi96
added a commit
to cernbox/reva
that referenced
this pull request
Oct 24, 2023
* For GRPC to EOS use the app context, not the passed one * Refresh compiling the eosgrpc proto * eos_grpc: small fixes * Add teststorageperf reva shell command * Refurbish the grpc and http plugins for eos * Add README for how to compile the grpc intf to eos * Add test self-referential release note * Modify test self-referential release note * Modify test self-referential release note * Cosmetics * NSRequests: use the background context to avoid grpc ugly bug * Fix lint warning * Close the body of an http get when not needed anymore * Fix lint warning * Set cmd timeout to 15s (allows uploading larger files to loaded servers) * eosgrpc: use a clean context derived from the original one * Makefile: use gaia to build revad * Fix lint warning * Add new target cernbox-revad, using gaia to build revad * go lint-fix * Update Makefile Co-authored-by: Gianmaria Del Monte <[email protected]> --------- Co-authored-by: Fabrizio Furano <[email protected]> Co-authored-by: Gianmaria Del Monte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refurbish the grpc and http plugins for eos