Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce/validate configuration of services #4035

Merged
merged 17 commits into from
Jul 5, 2023
Merged

Enforce/validate configuration of services #4035

merged 17 commits into from
Jul 5, 2023

Conversation

gmgigi96
Copy link
Member

@gmgigi96 gmgigi96 commented Jul 4, 2023 •
edited
Loading

Bail out if the configuration is not set.

For example, enabling one service with missing config, reva will fail to start and will log the following error:

2023-07-05 10:29:09.393 FTL ../../cmd/revad/main.go:244 > error creating reva runtime: http service sciencemesh could not be
 started: smtp_credentials is a required field, mesh_directory_url is a required field, provider_domain is a required field
 pid=1541549

@gmgigi96 gmgigi96 requested review from labkode, wkloucek, glpatcern and a team as code owners July 4, 2023 15:35
@cs3org cs3org deleted a comment from update-docs bot Jul 5, 2023
@labkode labkode merged commit bdc8b39 into cs3org:master Jul 5, 2023
abaldacchino pushed a commit to abaldacchino/reva that referenced this pull request Aug 25, 2023
@gmgigi96
Enforce/validate configuration of services (cs3org#4035)
e521e28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode labkode approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmgigi96 @labkode