-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New reva config #4015
Merged
Merged
New reva config #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmgigi96
force-pushed
the
reva-config
branch
2 times, most recently
from
June 28, 2023 14:55
3f2f8b2
to
9a650a8
Compare
gmgigi96
requested review from
labkode,
wkloucek,
glpatcern and
a team
as code owners
June 30, 2023 07:45
labkode
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context and Problem Statement
The configuration process for reva presents significant challenges due to its microservice architecture, which necessitates the repetition of configuration parameters across different parts of the services. To enable various drivers of the same service provider, such as LDAP, OIDC, and public shares as authentication providers, different TOML files are needed for each service.
Additionally, each microservice within reva requires the specification of a unique address, which demands a deep understanding of the reva architecture.
Collectively, these issues make it arduous for users to deploy a simplified (mono-process) version of reva.
Decision drivers
Decision Outcome
The configuration will contain a new
[vars]
section, containing all the common parameters used by different services.These variables, in the form of
name
:value
, can be recalled by a different part of the configuration, as values, using the sintax{{ vars.name }}
. The values can be of any type.For example:
To enable different drivers of the same provider, every provider configuration is a list:
It is still possible to declare only one provider, if it will be the only one in the configuration file.
Because the same provider cannot listen on the same port, every provider allow to specify an address in the form
host:port
.If the
address
variable is not provided, the runtime will allocate a random one. If other services have to refer to a provider address, the template{{ grpc.services.<name>[<index>].address }}
can be used. The list is 0-based indexed, and the order reflects the same as in the configuration file.A common address for all the services defined in the same toml file can be provider in the
[grpc]
section:Having a list of providers with the
grpc.address
variable is not allowed.