Fix listing directory for a read-only shares for EOS storage driver #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkode
approved these changes
Apr 11, 2023
gmgigi96
added a commit
to gmgigi96/reva
that referenced
this pull request
Jun 5, 2023
gmgigi96
added a commit
to gmgigi96/reva
that referenced
this pull request
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a read-only share, while listing a folder, for resources not having a version folder, the returned resource id was wrongly the one of the original file, instead of the version folder. This was causing problems for example in the open in app.
Even if the driver was trying to create a version folder, this was done on behalf of the recipient, which does not have enough permissions to create a resource in the folder.
This behavior has been fixed in this PR, where the version folder is always created on behalf of the resource owner, fixing the issue.