Remove space members #2524
Merged
Remove space members #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
C0rby
force-pushed
the
remove-space-members
branch
4 times, most recently
from
db4a1ef to
3562d92
Compare
C0rby
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
C0rby
force-pushed
the
remove-space-members
branch
from
9e40105 to
482e4cf
Compare
added 6 commits
February 14, 2022 14:34
The last manager of a space can not be removed. If the user should be removed then a new manager need to be set. After that the user can be removed.
The integration tests needed to be updated since I removed the owner from project spaces. Now the tests don't depend on an owner being set.
C0rby
force-pushed
the
remove-space-members
branch
from
482e4cf to
5a0a4fd
Compare
butonic
reviewed
Feb 15, 2022
| @@ -803,16 +806,18 @@ func (n *Node) ReadUserPermissions(ctx context.Context, u *userpb.User) (ap prov | |||
| o, err := n.Owner() | |||
| if err != nil { | |||
| // TODO check if a parent folder has the owner set? | |||
| appctx.GetLogger(ctx).Error().Err(err).Interface("node", n).Msg("could not determine owner, returning default permissions") | |||
| appctx.GetLogger(ctx).Error().Err(err).Str("node", n.ID).Msg("could not determine owner, returning default permissions") | |||
There was a problem hiding this comment.
I see what you did there ;-)
22 tasks
10 tasks
dragotin
pushed a commit
to butonic/reva
that referenced
this pull request
Feb 17, 2022
* remove owner from project spaces * block removal of last space manager The last manager of a space can not be removed. If the user should be removed then a new manager need to be set. After that the user can be removed. * check node properties instead of create-space permission * update integration tests The integration tests needed to be updated since I removed the owner from project spaces. Now the tests don't depend on an owner being set. * add changelog * add constants for space types and root node id
dragotin
added a commit
to butonic/reva
that referenced
this pull request
Feb 17, 2022
This reverts commit ce38775.
26 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delete request looks like this: