-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decomposedfs lookup outermost root #2373
Conversation
106affc
to
0060846
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
5e28dc9
to
743e7a3
Compare
This pull request introduces 1 alert when merging 743e7a3 into 5dde0ef - view on LGTM.com new alerts:
|
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
56be50c
to
99da3c0
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
// but that might be the personal space of another user where the current user has no access | ||
// so we need to take the "root" in the opaque and find its mount point for the current user | ||
// what is the root to which the path of the statResp is relative? | ||
rootId := &provider.ResourceId{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var rootId should be rootID
// but that might be the personal space of another user where the current user has no access | ||
// so we need to take the "root" in the opaque and find its mount point for the current user | ||
// what is the root to which the path of the statResp is relative? | ||
rootId := &provider.ResourceId{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var rootId should be rootID
// but that might be the personal space of another user where the current user has no access | ||
// so we need to take the "root" in the opaque and find its mount point for the current user | ||
// what is the root to which the path of the statResp is relative? | ||
rootId := &provider.ResourceId{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var rootId should be rootID
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
8b52ca4
to
b6ca718
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Closed in favor of making the gateway dumb again by moving the space lookup logic to clients, when the ocdav handler is one of them. |
When stating a resource by id the decomposedfs will now also return the outermost space root. This allows the gateway to properly reconstruct global paths by combining the space mountpoint and the relative path.
For the owner the root will be the space root, For share recipiens the root will be the outermost shared resource. For now, the root is returned as an opaque property.