Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify group and user managers to skip fetching specified metadata #2205

Merged
merged 4 commits into from
Feb 7, 2022
Merged

Modify group and user managers to skip fetching specified metadata #2205

merged 4 commits into from
Feb 7, 2022

Conversation

ishank011
Copy link
Contributor

No description provided.

@ishank011 ishank011 requested review from labkode and a team as code owners October 26, 2021 08:40
labkode
labkode previously approved these changes Oct 26, 2021
View reviewed changes
@labkode labkode self-requested a review October 26, 2021 10:10
@labkode labkode dismissed their stale review October 26, 2021 10:10

testing codeowners

@labkode labkode requested a review from a team October 26, 2021 10:11
@ishank011 ishank011 force-pushed the fetch-groups-members-config branch from 3f152fb to 21f1b59 Compare October 26, 2021 11:12
labkode
labkode previously approved these changes Oct 26, 2021
View reviewed changes
@labkode labkode self-requested a review October 28, 2021 14:42
labkode
labkode previously approved these changes Oct 28, 2021
View reviewed changes
refs
refs previously approved these changes Oct 29, 2021
View reviewed changes
@ishank011 ishank011 dismissed stale reviews from refs and labkode via 785a24c November 17, 2021 13:38
@ishank011 ishank011 force-pushed the fetch-groups-members-config branch from d1a050a to 785a24c Compare November 17, 2021 13:38
@labkode labkode self-requested a review November 18, 2021 09:53
labkode
labkode previously approved these changes Nov 18, 2021
View reviewed changes
@labkode labkode requested review from dragotin and refs November 18, 2021 09:54
@ishank011 ishank011 force-pushed the fetch-groups-members-config branch from faa8ae3 to dccc5a4 Compare February 2, 2022 10:59
@ishank011 ishank011 requested a review from glpatcern as a code owner February 2, 2022 10:59
@ishank011 ishank011 force-pushed the fetch-groups-members-config branch from dccc5a4 to c6e6293 Compare February 2, 2022 11:03
glpatcern
glpatcern approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, at the same time this touches on some fixes that had been introduced in #2007, could that be approved/merged as well?

@labkode labkode self-requested a review February 7, 2022 07:57
@labkode labkode requested a review from a team February 7, 2022 07:58
@butonic
Copy link
Contributor

butonic commented Feb 7, 2022 •
edited
Loading

LGTM

I think it makes sense to omit fetching members if they are not needed. While I don't see a problem with this PR @rhafer may have a deeper understanding of the user and group relationships. I currently cannot review this PR and 'accept' it because github gives me a 500 ... 😞

@ishank011 ishank011 merged commit 9e040c9 into cs3org:master Feb 7, 2022
@ishank011 ishank011 deleted the fetch-groups-members-config branch February 7, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern approved these changes

@labkode labkode labkode approved these changes

@dragotin dragotin Awaiting requested review from dragotin

@refs refs Awaiting requested review from refs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ishank011 @butonic @dragotin @labkode @glpatcern @refs