augment the id of newly created spaces

cs3org · Oct 12, 2021 · a864348 · a864348
1 parent 5dbb87c
commit a864348
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/changelog/unreleased/augment-spaces-id.md b/changelog/unreleased/augment-spaces-id.md
@@ -0,0 +1,5 @@
+Enhancement: Augment the Id of new spaces
+
+Newly created spaces were missing the Root reference and the storage id in the space id.
+
+https://github.com/cs3org/reva/issues/2158
diff --git a/internal/grpc/services/storageprovider/storageprovider.go b/internal/grpc/services/storageprovider/storageprovider.go
@@ -433,7 +433,14 @@ func (s *service) CreateHome(ctx context.Context, req *provider.CreateHomeReques
 
 // CreateStorageSpace creates a storage space
 func (s *service) CreateStorageSpace(ctx context.Context, req *provider.CreateStorageSpaceRequest) (*provider.CreateStorageSpaceResponse, error) {
-	return s.storage.CreateStorageSpace(ctx, req)
+	resp, err := s.storage.CreateStorageSpace(ctx, req)
+	if err != nil {
+		return nil, err
+	}
+
+	resp.StorageSpace.Root = &provider.ResourceId{StorageId: s.mountID, OpaqueId: resp.StorageSpace.Id.OpaqueId}
+	resp.StorageSpace.Id = &provider.StorageSpaceId{OpaqueId: s.mountID + "!" + resp.StorageSpace.Id.OpaqueId}
+	return resp, nil
 }
 
 func hasNodeID(s *provider.StorageSpace) bool {