-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add discovery endpoint #59
Conversation
@smesterheide do you mind having a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking it upon you to add the /ocm-provider endpoint.
Thanks Sandro @smesterheide! If also @michielbdejong can have a look, we can merge this ahead of the CS3 conference. |
What we need to add here at this stage is also the list of supported endpoints: funnily enough we discussed this with @schiessle at CS3 Barcelona, and @michielbdejong presented the same thing just minutes after. Additionally, we need to specify what are the minimal, required features from an EFSS (e.g., sharing with webdav protocol), and clearly mark any other endpoint/option as optional. I plan to address at least those issues prior to marking this ready for review / merge. |
I amended the discovery endpoint with what we agreed today, so it's ready for review. Up to @smesterheide and @michielbdejong whenever you can! |
0b2a981
to
ac8c3da
Compare
Co-authored-by: Sandro Mesterheide <[email protected]>
@smesterheide with the current changes we should be close to final, could you please have another look? |
This PR adds the
/ocm-provider
discovery endpoint, modeled after the already existing implementations.Also, the OCM API version is pushed to
2.0.0
, given the current state of thedevelop
branch. The goal is to agree on an official v2 release of the protocol at the CS3 event in Barcelona (see www.cs3community.org).Edit: we agreed we would have a dedicated OCM-related meeting, where this and other outstanding items are to be discussed. Out of that meeting (cf. also #69), this PR specifies the behavior of the current implementations, including the exposed version, and adds an optional
capabilities
property.In a future PR, we will push the version to
1.1.0
.Closes #51