Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discovery endpoint #59

Merged
merged 12 commits into from
Apr 14, 2023
Merged

Add discovery endpoint #59

merged 12 commits into from
Apr 14, 2023

Conversation

glpatcern
Copy link
Member

@glpatcern glpatcern commented Feb 16, 2023

This PR adds the /ocm-provider discovery endpoint, modeled after the already existing implementations.

Also, the OCM API version is pushed to 2.0.0, given the current state of the develop branch. The goal is to agree on an official v2 release of the protocol at the CS3 event in Barcelona (see www.cs3community.org).

Edit: we agreed we would have a dedicated OCM-related meeting, where this and other outstanding items are to be discussed. Out of that meeting (cf. also #69), this PR specifies the behavior of the current implementations, including the exposed version, and adds an optional capabilities property.

In a future PR, we will push the version to 1.1.0.

Closes #51

@glpatcern glpatcern marked this pull request as draft February 16, 2023 16:55
@glpatcern glpatcern marked this pull request as ready for review February 17, 2023 08:46
@glpatcern
Copy link
Member Author

@smesterheide do you mind having a look?

@glpatcern glpatcern requested a review from gmgigi96 February 17, 2023 08:58
Copy link
Contributor

@smesterheide smesterheide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking it upon you to add the /ocm-provider endpoint.

spec.yaml Outdated Show resolved Hide resolved
spec.yaml Show resolved Hide resolved
@glpatcern
Copy link
Member Author

Thanks Sandro @smesterheide! If also @michielbdejong can have a look, we can merge this ahead of the CS3 conference.

spec.yaml Outdated Show resolved Hide resolved
@glpatcern glpatcern marked this pull request as draft March 7, 2023 13:18
spec.yaml Outdated Show resolved Hide resolved
@glpatcern
Copy link
Member Author

What we need to add here at this stage is also the list of supported endpoints: funnily enough we discussed this with @schiessle at CS3 Barcelona, and @michielbdejong presented the same thing just minutes after.

Additionally, we need to specify what are the minimal, required features from an EFSS (e.g., sharing with webdav protocol), and clearly mark any other endpoint/option as optional.

I plan to address at least those issues prior to marking this ready for review / merge.

@glpatcern glpatcern marked this pull request as ready for review March 29, 2023 07:10
@glpatcern
Copy link
Member Author

I amended the discovery endpoint with what we agreed today, so it's ready for review. Up to @smesterheide and @michielbdejong whenever you can!

@glpatcern glpatcern requested a review from smesterheide March 29, 2023 14:53
@glpatcern glpatcern force-pushed the discovery branch 2 times, most recently from 0b2a981 to ac8c3da Compare March 29, 2023 19:54
@glpatcern glpatcern mentioned this pull request Mar 30, 2023
spec.yaml Outdated Show resolved Hide resolved
spec.yaml Show resolved Hide resolved
spec.yaml Outdated Show resolved Hide resolved
spec.yaml Outdated Show resolved Hide resolved
spec.yaml Show resolved Hide resolved
spec.yaml Outdated Show resolved Hide resolved
spec.yaml Outdated Show resolved Hide resolved
@glpatcern
Copy link
Member Author

@smesterheide with the current changes we should be close to final, could you please have another look?

@glpatcern glpatcern merged commit 44e5c14 into cs3org:develop Apr 14, 2023
@glpatcern glpatcern mentioned this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoint discovery through https://example.com/ocm-provider/
3 participants