Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debug info in case of name reuse #870

Merged
merged 4 commits into from
Aug 1, 2022
Merged

Improve debug info in case of name reuse #870

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8539c03
Improve debug info in case of name reuse
montyly Jun 22, 2021
64e20e2
Merge branch 'dev' into dev-naming
montyly Jun 23, 2021
0b230da
Merge branch 'dev' into dev-naming
montyly Aug 1, 2022
2b06b49
Minor
montyly Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions slither/solc_parsing/slither_compilation_unit_solc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ def parse_contracts(self): # pylint: disable=too-many-statements,too-many-branc
father_constructors = []
# try:
# Resolve linearized base contracts.
missing_inheritance = False
missing_inheritance = None

for i in contract_parser.linearized_base_contracts[1:]:
if i in contract_parser.remapping:
Expand All @@ -418,7 +418,7 @@ def parse_contracts(self): # pylint: disable=too-many-statements,too-many-branc
elif i in self._contracts_by_id:
ancestors.append(self._contracts_by_id[i])
else:
missing_inheritance = True
missing_inheritance = i

# Resolve immediate base contracts
for i in contract_parser.baseContracts:
Expand All @@ -432,7 +432,7 @@ def parse_contracts(self): # pylint: disable=too-many-statements,too-many-branc
elif i in self._contracts_by_id:
fathers.append(self._contracts_by_id[i])
else:
missing_inheritance = True
missing_inheritance = i

# Resolve immediate base constructor calls
for i in contract_parser.baseConstructorContractsCalled:
Expand All @@ -446,7 +446,7 @@ def parse_contracts(self): # pylint: disable=too-many-statements,too-many-branc
elif i in self._contracts_by_id:
father_constructors.append(self._contracts_by_id[i])
else:
missing_inheritance = True
missing_inheritance = i

contract_parser.underlying_contract.set_inheritance(
ancestors, fathers, father_constructors
Expand All @@ -456,7 +456,14 @@ def parse_contracts(self): # pylint: disable=too-many-statements,too-many-branc
self._compilation_unit.contracts_with_missing_inheritance.add(
contract_parser.underlying_contract
)
contract_parser.log_incorrect_parsing(f"Missing inheritance {contract_parser}")
txt = f"Missing inheritance {contract_parser.underlying_contract} ({contract_parser.compilation_unit.crytic_compile_compilation_unit.unique_id})\n"
txt += f"Missing inheritance ID: {missing_inheritance}\n"
if contract_parser.underlying_contract.inheritance:
txt += "Inheritance found:\n"
for contract_inherited in contract_parser.underlying_contract.inheritance:
txt += f"\t - {contract_inherited} (ID {contract_inherited.id})\n"
contract_parser.log_incorrect_parsing(txt)

contract_parser.set_is_analyzed(True)
contract_parser.delete_content()

Expand Down