Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect type conversion in case of libraries lookup name collision #827

Merged
merged 3 commits into from
Apr 22, 2021

Conversation

montyly
Copy link
Member

@montyly montyly commented Apr 21, 2021

Slither was incorrectly converted some of the types in case of implicit conversion on library lookup

Ex:

library Lib{
    function t(uint, uint8) internal returns(uint){
        return 0x1;
    }
    function t(uint, uint256) internal returns(uint){
        return 0x32;
    }

}


contract Test{
    function test() public view returns(uint){
        uint a;
        return a.t(0x10);
    }
}

The IR would incorrectly uses t(uint, uint256).

@montyly montyly merged commit 115066c into dev Apr 22, 2021
@montyly montyly deleted the dev-fix-implicit-type-conversion branch April 22, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant