add unused-return-transfers detector + update unused-return #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from unused-return detector
|
This pull request introduces 1 alert when merging 2780549 into cf07c59 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 9b98792 into cf07c59 - view on LGTM.com new alerts:
|
- Inherits from Unused return (avoid duplicate code) - Rename unchecked-return - Update description/recommendations Additionally removed txt_description from all the UnusedReturn derived class (its not used anymore)
|
This pull request introduces 1 alert when merging c2f7773 into cf07c59 - view on LGTM.com new alerts:
|
|
I made the following changes:
Additionally removed txt_description from all the UnusedReturn derived |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #816
unused-return-transfersunused-returnto excludetransfer/transferFromcalls, since they are caught by the new detector.