API changes #58
Merged
API changes #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use slihtIR for node.state_vars read/write and calls - remove external_calls of node/function, split into node.low_level_calls/high_level_calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses slihtIR to improve the following attributes of
nodeandfunction:variables_readvariables_writtenstate_variables_readstate_variables_writteninternal_callIt replaces the attribute
external_callsby:solidity_calls: returns the list ofSolidiyFunctioncalledhigh_level_calls: returns the list of(Contract, Function|Variable)called (it includes library calls).Variableis used for calls to public state variables.low_level_calls: returns the list of low level calls, represented by(Variable|SolidityVariable, function_name), wherefunction_namecan becall/delegatecall/codecallThe PR should simplify the detectors and will be directly useful for #49 and #56
I am waiting to merge the PR into
dev, as it breaks the API used by other PRs