Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional optimizations for similar_variables.py #1980

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Additional optimizations for similar_variables.py #1980

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e709fd
additional optimizations for similar_variables.py
0xGusMcCrae Jun 10, 2023
b89ca1a
linting
0xGusMcCrae Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions slither/detectors/variables/similar_variables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ def similar(seq1: str, seq2: str) -> bool:
Returns:
bool: true if names are similar
"""
if len(seq1) != len(seq2):
return False
val = difflib.SequenceMatcher(a=seq1.lower(), b=seq2.lower()).ratio()
val = difflib.SequenceMatcher(a=seq1, b=seq2).ratio()
ret = val > 0.90
return ret

Expand All @@ -67,19 +65,21 @@ def detect_sim(contract: Contract) -> Set[Tuple[LocalVariable, LocalVariable]]:

all_var = list(set(all_var + contract_var))

ret = []
ret = set()
# pylint: disable=consider-using-enumerate
for i in range(len(all_var)):
v1 = all_var[i]
_v1_name_lower = v1.name.lower()
for j in range(i, len(all_var)):
v2 = all_var[j]
if _v1_name_lower != v2.name.lower():
if SimilarVarsDetection.similar(v1.name, v2.name):
if (v2, v1) not in ret:
ret.append((v1, v2))
if len(v1.name) != len(v2.name):
continue
_v2_name_lower = v2.name.lower()
if _v1_name_lower != _v2_name_lower:
if SimilarVarsDetection.similar(_v1_name_lower, _v2_name_lower):
ret.add((v1, v2))

return set(ret)
return ret

def _detect(self) -> List[Output]:
"""Detect similar variables name
Expand Down