Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed canonical_name of event #1974

Closed
wants to merge 2 commits into from
Closed

Fixed canonical_name of event #1974

wants to merge 2 commits into from

Conversation

0xxfu
Copy link
Contributor

@0xxfu 0xxfu commented Jun 20, 2023

No description provided.

@0xalpharush
Copy link
Contributor

0xalpharush commented Jun 20, 2023 •
edited
Loading

It looks like the detector tests need to be updated since this affects the format. Can you run pytest tests/e2e/detectors/test_detectors.py --insta update on your branch of slither and commit the updates please?

@0xalpharush 0xalpharush mentioned this pull request Jun 21, 2023
Merged
@montyly
Copy link
Member

montyly commented Jun 22, 2023

Great catch, thanks @0xxfu. This was merged with #1976

@montyly montyly closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montyly montyly Awaiting requested review from montyly montyly is a code owner

@0xalpharush 0xalpharush Awaiting requested review from 0xalpharush

@smonicas smonicas Awaiting requested review from smonicas smonicas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xxfu @0xalpharush @montyly