Added support for Embark repos #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
- rename force-embark-plugin to embark-overwrite-config
- add the flag to the slither config file
- fix incorrect Slither initialization
- change logic:
- only install the plugin if config file is written
- improve error handling
- do not write contracts ast to an external file
- do not remove the ast file generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Embark (https://embark.status.im/) repositories.
On running
slither .in the top-level directory of an Embark repo which contains the Embark config fileembark.json, Slither detects the presence of this config file and looks for the Embark pluginembark-contract-infoin the config file. If found, it installs the plugin and then runsembark build --contractsto compile the contracts in the repo. The plugin gets triggered on the compilation to produce a file which contains AST, ABI, bytecode, etc. of the contracts. The AST files are used by Slither to run its analyses.To do: Replace the npm install from git to a registered package.