Add setter for self._web3
in SlitherReadStorage
#1839
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds setter for
self._web3
in SlitherReadStorage for more flexibility using SRS in other tools.SlitherReadStorage._web3
depends onSlitherReadStorage.rpc
, which is not protected, so it would seem simple enough to just set the RPC if we want to set up our own Web3 provider.However, in my project I already have a Web3 provider created, and I need to do the following to handle PoA networks:
I would then like to set
srs.web3 = self._w3
so that subsequent calls tosrs.get_slot_values
will work with PoA networks.I suppose the alternative is for my program to store
is_poa
for later, and then do the following, though this is only necessary because there is nosrs.web3
setter: