incorrect-equality: do not check addresses #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
i really don't think these errors have anything to do with my changes, can you please rerun the ci? |
ydm
force-pushed
the
master
branch
3 times, most recently
from
798e8e3 to
9dc5167
Compare
|
should be good now? |
0xalpharush
reviewed
Mar 13, 2023
| Comparing addresses strictly should not be flagged. | ||
| """ | ||
| addr = ElementaryType("address") | ||
| return ir.variable_left.type != addr or ir.variable_right.type != addr |
There was a problem hiding this comment.
If something like Contract(address(0x0)) == Contract(address(0x0)) is used, is_not_comparing_addresses won't filter it out. We would need to add something like isinstance(ir.variable_left.type, UserDefinedType) and isinstance(ir.variable_left.type.type, Contract). It'd be helpful to add a test case for both the address and contract case so that we can be sure of the modifications and prevent regressions in the future.
|
Casting my support of this PR. The wiki about this detector mentions a use case that should never be relevant for address checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a simple additional check to make sure no strict equality of addresses is flagged at all.