Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enums to echidna printer's list of constants #1665

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Add enums to echidna printer's list of constants #1665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion slither/printers/guidance/echidna.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from slither.analyses.data_dependency.data_dependency import is_dependent
from slither.core.cfg.node import Node
from slither.core.declarations import Function
from slither.core.declarations import Enum, Function
from slither.core.declarations.solidity_variables import (
SolidityVariableComposed,
SolidityFunction,
Expand Down Expand Up @@ -186,6 +186,17 @@ def _extract_constants_from_irs( # pylint: disable=too-many-branches,too-many-n
if isinstance(ir.variable, Constant):
all_cst_used.append(ConstantValue(str(ir.variable.value), str(ir.type)))
continue
if (
isinstance(ir, Member)
and isinstance(ir.variable_left, Enum)
and isinstance(ir.variable_right, Constant)
):
# enums are constant values
try:
internal_num = ir.variable_left.values.index(ir.variable_right.value)
all_cst_used.append(ConstantValue(str(internal_num), "uint256"))
except ValueError: # index could fail; should never happen in working solidity code
pass
for r in ir.read:
# Do not report struct_name in a.struct_name
if isinstance(ir, Member):
Expand Down