Fix external-function detector to avoid false-positives #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- functions_inherited - functions_not_inherited - modifiers_inherited - modifiers_not_inherited - functions_and_modifiers_inherited - functions_and_modifiers_not_inherited - functions_entry_points - get_functions_overridden_by
- Remove contract.get_functions_overridden_by - Add function.functions_shadowed
…ult of inheritance.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to resolve #118 . Fixes the handling of the
external-functiondetector such that it takes into account calls to base + overriding functions, and respects unified visibility conventions between all definitions.This rewrites most of the original detector logic and should be reviewed thoroughly. It has been tested on the example referenced in the above issue, and all tests in the
\tests\directory to ensure no false-positives.It should also be noted that this branch is also based off of the
dev-api-contractbranch, which has not yet been merged to master.