feat: add arbitrary-send-erc20 and arbitrary-send-erc20-permit detectors #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xalpharush
force-pushed
the
feat/send-arbitrary-erc20
branch
from
cd9b9e0 to
8e66b66
Compare
|
This pull request introduces 2 alerts when merging 8e66b66 into de0d526 - view on LGTM.com new alerts:
|
0xalpharush
force-pushed
the
feat/send-arbitrary-erc20
branch
2 times, most recently
from
1df2a69 to
2cdecf9
Compare
|
This pull request introduces 2 alerts when merging 2cdecf9 into f7b55bc - view on LGTM.com new alerts:
|
|
TODO: Need to fix false negative in #block-slither before merging |
0xalpharush
force-pushed
the
feat/send-arbitrary-erc20
branch
2 times, most recently
from
f828c6f to
438b529
Compare
|
This pull request introduces 2 alerts when merging 438b529 into 75a9766 - view on LGTM.com new alerts:
|
0xalpharush
force-pushed
the
feat/send-arbitrary-erc20
branch
from
438b529 to
2e7f1f1
Compare
|
This pull request introduces 2 alerts when merging 2e7f1f1 into e94e02e - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
from-TransferFromdetector by splitting it into arbitrary-send-erc20 and arbitrary-send-erc20-permit, so that the guidance/ exploit scenario is different. Also, I changed thearbitrary-senddetector toarbitrary-send-ethfor clarity.