Merge pull request #729 from crytic/add-printer-name-to-graph-printers

Add more descriptive names to inheritance-graph + call-graph printers outputted files
crytic · Dec 15, 2020 · 1c12a13 · 1c12a13
2 parents b617195 + 03e2a93
commit 1c12a13
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/slither/printers/call/call_graph.py b/slither/printers/call/call_graph.py
@@ -178,29 +178,31 @@ def output(self, filename):
             filename(string)
         """
 
+        all_contracts_filename = ""
         if not filename.endswith(".dot"):
-            filename += ".dot"
+            all_contracts_filename = f"{filename}.all_contracts.call-graph.dot"
         if filename == ".dot":
-            filename = "all_contracts.dot"
+            all_contracts_filename = "all_contracts.dot"
 
         info = ""
         results = []
-        with open(filename, "w", encoding="utf8") as f:
-            info += f"Call Graph: {filename}\n"
+        with open(all_contracts_filename, "w", encoding="utf8") as f:
+            info += f"Call Graph: {all_contracts_filename}\n"
             content = "\n".join(
                 ["strict digraph {"] + [_process_functions(self.slither.functions)] + ["}"]
             )
             f.write(content)
-            results.append((filename, content))
+            results.append((all_contracts_filename, content))
 
         for derived_contract in self.slither.contracts_derived:
-            with open(f"{derived_contract.name}.dot", "w", encoding="utf8") as f:
-                info += f"Call Graph: {derived_contract.name}.dot\n"
+            derived_output_filename = f"{filename}.{derived_contract.name}.call-graph.dot"
+            with open(derived_output_filename, "w", encoding="utf8") as f:
+                info += f"Call Graph: {derived_output_filename}\n"
                 content = "\n".join(
                     ["strict digraph {"] + [_process_functions(derived_contract.functions)] + ["}"]
                 )
                 f.write(content)
-                results.append((filename, content))
+                results.append((derived_output_filename, content))
 
         self.info(info)
         res = self.generate_output(info)

diff --git a/slither/printers/inheritance/inheritance_graph.py b/slither/printers/inheritance/inheritance_graph.py
@@ -193,7 +193,7 @@ def output(self, filename):
         if filename == "":
             filename = "contracts.dot"
         if not filename.endswith(".dot"):
-            filename += ".dot"
+            filename += ".inheritance-graph.dot"
         info = "Inheritance Graph: " + filename + "\n"
         self.info(info)