Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update sierra file stem #45

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Conversation

tserg
Copy link
Contributor

@tserg tserg commented Sep 8, 2023

Update .sierra to .contract_class as per software-mansion/scarb#610

@tserg tserg requested a review from smonicas as a code owner September 8, 2023 03:42
@smonicas
Copy link
Collaborator

smonicas commented Sep 8, 2023

Hi thanks for your PR. If i understand correctly this will be from the next scarb version however i believe we should maintain backward compatibility with older scarb versions. I think checking if it ends with .sierra or .contract_class should work just fine. What do you think?

@tserg
Copy link
Contributor Author

tserg commented Sep 8, 2023

Hi thanks for your PR. If i understand correctly this will be from the next scarb version however i believe we should maintain backward compatibility with older scarb versions. I think checking if it ends with .sierra or .contract_class should work just fine. What do you think?

Hi, good point! I will make the changes.

@tserg
Copy link
Contributor Author

tserg commented Sep 14, 2023

Hi @smonicas, any update on the next steps? We are pending this to integrate Caracal into our CI.

@smonicas
Copy link
Collaborator

Hi, sorry i didn't imagine that you were using an unreleased scarb version but we'll do a release next week

@smonicas smonicas merged commit 8dc26ae into crytic:master Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants