Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSSC Solana #181

Merged
merged 28 commits into from
Jan 11, 2023
Merged

NSSC Solana #181

merged 28 commits into from
Jan 11, 2023

Conversation

suryansh-tob
Copy link
Contributor

  • Create NSSC Solana
  • Add Sysvar Account Check section

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@suryansh-tob
Update README.md
34ab59c 
- Example contract added
- Exploit scenario simplified
- Fixed Mitigation
@suryansh-tob suryansh-tob requested a review from montyly December 19, 2022 01:26
smoelius
smoelius reviewed Jan 6, 2023
View reviewed changes
Copy link
Member

@smoelius smoelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are pretty nitpicky. Overall, this is a very impressive piece of work.

not-so-smart-contracts/solana/improper_pda_validation/README.md Outdated Show resolved Hide resolved
not-so-smart-contracts/solana/improper_pda_validation/README.md Outdated Show resolved Hide resolved
not-so-smart-contracts/solana/ownership_check/README.md Outdated Show resolved Hide resolved
not-so-smart-contracts/solana/signer_check/README.md Outdated Show resolved Hide resolved
not-so-smart-contracts/solana/ownership_check/README.md Outdated Show resolved Hide resolved
not-so-smart-contracts/solana/sysvar_account_check/README.md Show resolved Hide resolved
not-so-smart-contracts/solana/sysvar_account_check/README.md Outdated Show resolved Hide resolved
not-so-smart-contracts/solana/signer_check/README.md Outdated Show resolved Hide resolved
not-so-smart-contracts/solana/ownership_check/README.md Outdated Show resolved Hide resolved
not-so-smart-contracts/solana/signer_check/README.md Outdated Show resolved Hide resolved
suryansh-tob and others added 8 commits January 5, 2023 22:55
@suryansh-tob @smoelius
Small fixes
dd84d05 
Co-authored-by: Samuel Moelius <[email protected]>
@suryansh-tob @smoelius
Update Improper PDA Validation mitigation
5fb8bc0 
Co-authored-by: Samuel Moelius <[email protected]>
@suryansh-tob @smoelius
Small fixes
b988661 
Co-authored-by: Samuel Moelius <[email protected]>
@suryansh-tob @smoelius
Small fixes
ce29887 
Co-authored-by: Samuel Moelius <[email protected]>
@suryansh-tob @smoelius
Small fixes
1a63c2c 
Co-authored-by: Samuel Moelius <[email protected]>
@suryansh-tob
Update README.md
1af964a
@suryansh-tob @smoelius
Small fixes
f01c709 
Co-authored-by: Samuel Moelius <[email protected]>
@suryansh-tob @smoelius
Small fixes
843902b 
Co-authored-by: Samuel Moelius <[email protected]>
suryansh-tob and others added 2 commits January 5, 2023 23:07
@suryansh-tob @smoelius
Small fixes
d375cf0 
Co-authored-by: Samuel Moelius <[email protected]>
@suryansh-tob
Small fixes
e2c2b7b
@montyly montyly merged commit 65fa300 into master Jan 11, 2023
@montyly montyly deleted the nssc-solana-sysvar branch January 11, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoelius smoelius smoelius left review comments

@montyly montyly Awaiting requested review from montyly montyly is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suryansh-tob @CLAassistant @montyly @smoelius