Fix pkconfig path lookup using brew --prefix
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second commit fixes a CI failure for an antique Crystal version which is already disabled on |
oprypin
approved these changes
Apr 26, 2024
|
I suppose I'll make a release now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The homebrew installation directory moved from
/usr/local/Cellarto/opt/homebrew/Cellarin the latest update of the GitHub Actions runner image (actions/runner-images#9728).The former path was hard coded in the install action, and as a result pkgconfig information for openssl could not be found.
This patch queries
brew --prefixto get the installation directory.