Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
#to_a
is identical to its yielding variant#to_a(&)
. We can simply delegate to#to_a(&)
.As a bonus, inheriting types which override
#to_a(&)
with an optimized implementation will implicitly use the same optimization for#to_a
as well. This means we can dropIndexable#to_a
.Inheriting types
Tuple
andHash
already explicitly delegate#to_a
to their override implementations of#to_a(&)
.We probably want to keep these overrides of
#to_a
because they augment the documentation.But we can replace the method bodies with
super
to make it clear that the behaviour is inherited and thedef
only provides documentation.