MT: reduce interleaved backtraces in spawn unhandled exceptions #14220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing many individual writes to STDERR that may happen concurrently with other threads, we buffer the message in memory so we can write once.
I tried with 10 000 fibers and 16 threads and I couldn't get any interleaved message. That doesn't mean it can't happen, especially with other concurrent writes to STDERR —which an alternative solution to use a mutex wouldn't prevent it either.
Note: I chose to use a HEAP allocated buffer rather than a stack allocated one because the latter wouldn't be resizeable, and there is no guarantee that the backtrace would fit within 4KB (
PIPE_BUF
on Linux).closes #8299