Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dll parameter in @[Link] #14131

Merged

Conversation

HertzDevil
Copy link
Contributor

Resolves #13858.

Unlike the initial proposal, dll no longer accepts an array of strings. Libs can simply use @[Link] multiple times.

@HertzDevil HertzDevil added kind:feature topic:compiler platform:windows Windows support based on the MSVC toolchain / Win32 API topic:lang:annotations labels Dec 21, 2023
src/annotations.cr Outdated Show resolved Hide resolved
Co-authored-by: Johannes Müller <[email protected]>
@straight-shoota straight-shoota added this to the 1.11.0 milestone Dec 21, 2023
@straight-shoota straight-shoota merged commit 899ec69 into crystal-lang:master Dec 23, 2023
55 of 56 checks passed
@HertzDevil HertzDevil deleted the feature/link-annotation-dll branch December 23, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:compiler topic:lang:annotations
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Actually installing DLLs via @[Link]
2 participants