Protect class_(getter|property)[?] using Crystal.once(&).

crystal-lang · Jan 30, 2025 · a888edb · a888edb
1 parent 7b15af9
commit a888edb
Show file tree

Hide file tree

Showing 2 changed files with 62 additions and 16 deletions.
diff --git a/scripts/generate_object_properties.cr b/scripts/generate_object_properties.cr
@@ -35,20 +35,46 @@ struct Generator
   end
 
   def def_getter(suffix = "")
+    if @macro_prefix == "class_"
+      def_class_getter suffix
+    else
+      <<-TEXT
+            def {{var_name}}#{suffix} {% if type %} : {{type}} {% end %}
+              {% if block %}
+                if (%value = @{{var_name}}).nil?
+                  @{{var_name}} = {{yield}}
+                else
+                  %value
+                end
+              {% else %}
+                @{{var_name}}
+              {% end %}
+            end
+
+      TEXT
+    end
+  end
+
+  def def_class_getter(suffix = "")
     <<-TEXT
-          def #{@method_prefix}{{var_name}}#{suffix} {% if type %} : {{type}} {% end %}
-            {% if block %}
-              if (%value = #{@var_prefix}{{var_name}}).nil?
-                #{@var_prefix}{{var_name}} = {{yield}}
-              else
-                %value
-              end
-            {% else %}
-              #{@var_prefix}{{var_name}}
-            {% end %}
-          end
+            {% if block %} @@__{{var_name}}_flag = false {% end %}
+
+            def self.{{var_name}}#{suffix} {% if type %} : {{type}} {% end %}
+              {% if block %}
+                if (%value = @@{{var_name}}).nil?
+                  ::Crystal.once(pointerof(@@__{{var_name}}_flag)) do
+                    @@{{var_name}} = {{yield}} if @@{{var_name}}.nil?
+                  end
+                  @@{{var_name}}.not_nil!
+                else
+                  %value
+                end
+              {% else %}
+                @@{{var_name}}
+              {% end %}
+            end
 
-    TEXT
+      TEXT
   end
 
   def def_vars!

diff --git a/src/object/properties.cr b/src/object/properties.cr
@@ -993,10 +993,15 @@ class Object
         {% type = nil %}
       {% end %}
 
+      {% if block %} @@__{{var_name}}_flag = false {% end %}
+
       def self.{{var_name}} {% if type %} : {{type}} {% end %}
         {% if block %}
           if (%value = @@{{var_name}}).nil?
-            @@{{var_name}} = {{yield}}
+            ::Crystal.once(pointerof(@@__{{var_name}}_flag)) do
+              @@{{var_name}} = {{yield}} if @@{{var_name}}.nil?
+            end
+            @@{{var_name}}.not_nil!
           else
             %value
           end
@@ -1120,10 +1125,15 @@ class Object
         {% type = nil %}
       {% end %}
 
+      {% if block %} @@__{{var_name}}_flag = false {% end %}
+
       def self.{{var_name}}? {% if type %} : {{type}} {% end %}
         {% if block %}
           if (%value = @@{{var_name}}).nil?
-            @@{{var_name}} = {{yield}}
+            ::Crystal.once(pointerof(@@__{{var_name}}_flag)) do
+              @@{{var_name}} = {{yield}} if @@{{var_name}}.nil?
+            end
+            @@{{var_name}}.not_nil!
           else
             %value
           end
@@ -1469,10 +1479,15 @@ class Object
         {% type = nil %}
       {% end %}
 
+      {% if block %} @@__{{var_name}}_flag = false {% end %}
+
       def self.{{var_name}} {% if type %} : {{type}} {% end %}
         {% if block %}
           if (%value = @@{{var_name}}).nil?
-            @@{{var_name}} = {{yield}}
+            ::Crystal.once(pointerof(@@__{{var_name}}_flag)) do
+              @@{{var_name}} = {{yield}} if @@{{var_name}}.nil?
+            end
+            @@{{var_name}}.not_nil!
           else
             %value
           end
@@ -1611,10 +1626,15 @@ class Object
         {% type = nil %}
       {% end %}
 
+      {% if block %} @@__{{var_name}}_flag = false {% end %}
+
       def self.{{var_name}}? {% if type %} : {{type}} {% end %}
         {% if block %}
           if (%value = @@{{var_name}}).nil?
-            @@{{var_name}} = {{yield}}
+            ::Crystal.once(pointerof(@@__{{var_name}}_flag)) do
+              @@{{var_name}} = {{yield}} if @@{{var_name}}.nil?
+            end
+            @@{{var_name}}.not_nil!
           else
             %value
           end