fix: set window option properly (nodejs#2048)

* fix: set window option properly * Update lib/fetch/request.js Co-authored-by: Robert Nagy <[email protected]> * Update lib/fetch/request.js Co-authored-by: Robert Nagy <[email protected]> * add test --------- Co-authored-by: Robert Nagy <[email protected]>
crysmags · Feb 27, 2024 · a1d3678 · a1d3678
1 parent d4e4ae0
commit a1d3678
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/fetch/request.js b/lib/fetch/request.js
@@ -133,7 +133,7 @@ class Request {
     }
 
     // 11. If init["window"] exists, then set window to "no-window".
-    if (init.window !== undefined) {
+    if ('window' in init) {
       window = 'no-window'
     }
 

diff --git a/test/fetch/407-statuscode-window-null.js b/test/fetch/407-statuscode-window-null.js
@@ -0,0 +1,20 @@
+'use strict'
+
+const { fetch } = require('../..')
+const { createServer } = require('http')
+const { once } = require('events')
+const { test } = require('tap')
+
+test('Receiving a 407 status code w/ a window option present should reject', async (t) => {
+  const server = createServer((req, res) => {
+    res.statusCode = 407
+    res.end()
+  }).listen(0)
+
+  t.teardown(server.close.bind(server))
+  await once(server, 'listening')
+
+  // if init.window exists, the spec tells us to set request.window to 'no-window',
+  // which later causes the request to be rejected if the status code is 407
+  await t.rejects(fetch(`http://localhost:${server.address().port}`, { window: null }))
+})